search

getumbrel / umbrel-os

umbrelOS for Raspberry Pi 4 (only). Covert your Raspberry Pi into a home server in one click. For other hardware, checkout https://github.com/getumbrel/umbrel
https://umbrel.com
BSD 3-Clause "New" or "Revised" License
586 stars 55 forks source link

Add docker to dependencies #152

Closed AaronDewes closed 3 years ago

lukechilds commented 3 years ago

@AaronDewes is this needed if we manually install Docker?

https://github.com/getumbrel/umbrel-os/blob/2e743a21504afc42736fae613bad203e64cfcb9b/stage2/03-install-umbrel/01-run.sh#L11

AaronDewes commented 3 years ago

We install it in the final system. The depends file checks for host dependencies, and because Docker doesn't work in the chroot, it's pulled on the host https://github.com/getumbrel/umbrel-os/blob/2e743a21504afc42736fae613bad203e64cfcb9b/stage2/03-install-umbrel/01-run.sh#L77.

lukechilds commented 3 years ago

Got it, thanks!