getumbrel / umbrel-os

umbrelOS for Raspberry Pi 4 (only). Covert your Raspberry Pi into a home server in one click. For other hardware, checkout https://github.com/getumbrel/umbrel
https://umbrel.com
BSD 3-Clause "New" or "Revised" License
586 stars 55 forks source link

Add more USB storage quirks #168

Closed AaronDewes closed 3 years ago

AaronDewes commented 3 years ago

:-( Please no more quirks

B-zwitsal commented 3 years ago

i got the following message:

usb_storage.quirks: string doesn't fit in 127 chars.

and it seems that the quirks are ignored if you add too many

louneskmt commented 3 years ago

@B-zwitsal https://github.com/getumbrel/umbrel/pull/580 This might help, as it (normally) adds automatically the quirk to usb_storage.quirks if the issue is detected. So it will be possible to have an empty string for usb_storage.quirks and if necessary add only the user drive uas string, instead of having a long string containing all the quirks for a lot of drives.

Am I wrong @AaronDewes?