getumbrel / umbrel-os

umbrelOS for Raspberry Pi 4 (only). Covert your Raspberry Pi into a home server in one click. For other hardware, checkout https://github.com/getumbrel/umbrel
https://umbrel.com
BSD 3-Clause "New" or "Revised" License
590 stars 55 forks source link

Enable Umbrel systemd services at build #89

Closed mayankchhabra closed 4 years ago

mayankchhabra commented 4 years ago

This removes the need of having, updating and maintaining a boot script that's executed via rc.local and also decreases the first boot time.

Another benefit of not having a boot script is to not worry about where the boot script is executed from (external storage or SD card). The only thing we need to update now during OTA updates is installing the systemd services, and that's it.

Also, MUDA!

Related: https://github.com/getumbrel/umbrel/pull/126

lukechilds commented 4 years ago

Looks good.

The only thing we need to update now during OTA updates is installing the systemd services, and that's it.

I still think we should update the entire SD card install on OTA updates. For example if the user upgrades the SSD in the future we'll copy the SD card Umbrel install over to it during reformatting. If the services are out of sync with the Umbrel install that could cause issues.

mayankchhabra commented 4 years ago

Oh, yes we should definitely upgrade the SD card version too. Sorry I wrongly worded this:

The only thing we need to update now during OTA updates is installing the systemd services, and that's it.