getumbrel / umbrel

A beautiful home server OS for self-hosting with an app store. Buy a pre-built Umbrel Home with umbrelOS, or install on a Raspberry Pi or any x86 system.
https://umbrel.com
Other
7.56k stars 538 forks source link

Changing the ID of a community app store breaks the app store with no error #1912

Open jleaders opened 1 month ago

jleaders commented 1 month ago

Repro steps:

"Use this template" on https://github.com/getumbrel/umbrel-community-app-store.git

Don't change anything, add the Git URL to umbrel, note that it works perfectly and you can see the app

image

Then simply change the id to "sparkles-break" and name to "Sparkles 2" - commit, push

Remove the app store and re add it with the same git URL, note it will no longer show any apps

image

mayankchhabra commented 1 month ago

Thanks for reporting @jleaders! Have you tried updating the app id as well? I.e. update the app folder's name to sparkles-break-hello-world and set the id inside sparkles-break-hello-world/umbrel-app.yml to sparkles-break-hello-world. That should do it.