getwilds / cancerprof

API Client for State Cancer Profiles
http://getwilds.org/cancerprof/
Other
2 stars 3 forks source link

Response URLs #121

Closed howardbaik closed 2 months ago

howardbaik commented 3 months ago

Having read through the source code for demo_crowding() and demo_education() in the dev branch, I noticed that we assign a variable for resp$url: https://github.com/getwilds/cancerprof/blob/c51290cb1810d421d53321ab1ebe2895b9635734/R/demo-crowding.R#L72 https://github.com/getwilds/cancerprof/blob/c51290cb1810d421d53321ab1ebe2895b9635734/R/demo-education.R#L92

I don't think this is necessary since the response URL shouldn't be different from the request URL (unless there were redirects, which we can safely assume there won't be).

We should be getting the same url as resp$url from req$url, so I don't think we need to assign a new variable, resp_url.

What do you think?