search

getwilds / rcromwell

R client for interacting with Cromwell with WDL workflows
http://getwilds.org/rcromwell/
Other
4 stars 2 forks source link

small cosmetic suggestion for cromwell_jobs() #42

Closed jayoung closed 1 month ago

jayoung commented 3 months ago

hi there,

as I explore rcromwell, I can tell that every time I run cromwell_jobs() I'm going to want to do something like this every time:

cromwell_jobs() %>% print(width=Inf)

or even better, this

cromwell_jobs() %>% relocate(workflow_name, status, submission, start) %>% print(width=Inf)

So my suggestion is to make cromwell_jobs() arrange the columns of its output tibble in a user-friendly order.

picky! sorry.

Janet

jayoung commented 3 months ago

another cosmetic-ish thing: how about making cromwell_call() emit its output as a tibble (rather than data.frame), to be consistent with the output of cromwell_jobs() ? Either tibble or data.frame is good but consistency between functions in the same package is nice.

tefirman commented 2 months ago

@jayoung -- Totally agree on the column order of cromwell_jobs, it would be much more convenient in the order we have it on the "Workflows Run" table of the Shiny app (see screenshot below). We can definitely fix that!

As for the cromwell_call output, I'm seeing that returning tibbles on my end. Is there a particular job you used that returned a data.frame (job ID, WDL script, etc)?

image

jayoung commented 1 month ago

thanks, Taylor - glad my small comments are not annoying!

Don't think I'll be able to reconstruct the cromwell_call -> data.frame thing - sorry! It's too long ago now that I saw that. I'm not using WDLs very often. If I do see it again I'll try to remember to give you a job ID, but maybe we should just assume that I imagined it :)

sckott commented 1 month ago

Thanks @jayoung

Made fixes for these two functions in PR #46