getwilds / rcromwell

R client for interacting with Cromwell with WDL workflows
http://getwilds.org/rcromwell/
Other
4 stars 2 forks source link

Testing improvements #44

Open sckott opened 2 months ago

sckott commented 2 months ago

It'd be nice to test with the latest few versions of Cromwell, e.g., https://github.com/broadinstitute/cromwell/releases/tag/87 came out in May, and it'd be nice to test this pkg with 86 and 87 at least.

For that to work easily, i'd like to make it so that tests could be run both:

Maybe it would work to somehow detect if we're inside a vcr::use_cassette block and vcr is turned off or on and behave accordingly, all in vcr::use_cassette block:

The sleep/wait above could just be a Sys.sleep, or could be a retry situation with some backoff, or just same time gaps between each call until we get a 200 response

Once this is working, then idea is to have a matrix approach in the github actions yml file to test under different cromwell versions

tefirman commented 2 months ago

I feel very similarly to this issue as I do to #26 and #28, very important and could potentially be done now since rcromwell won't change much in v2.0 and the benefits would carry over, but it would require somewhat significant lift. Marking as v2.0 for now, but definitely could be convinced to put this in v1.X, especially if we can get all other high priority items done.