Closed julianhess closed 3 years ago
Honestly the imputation with sklearn works great for KNN. I should just remove missingpy
for the next release and fix setup.py
Thanks for the heads up!
Removed missingpy
from setup.py
and the function that calls it.
With a recent version of sklearn, importing signatureanalyzer returns the following error:
This is because sklearn renamed
sklearn.neighbors.base
tosklearn.neighbors._base
. A PR has been submitted to missingpy, but it appears that repo is dead (hasn't been updated since 2018): https://github.com/EvilTrtl/missingpy/tree/patch-1Installing missingpy from that branch fixes the issue. We may want to amend setup.py to do the same, until the missingpy folks update their repo (if ever).