search

getzlab / dalmatian

dalmatian is a collection of high-level companion functions for Firecloud and FISS.
18 stars 13 forks source link

dry_run logic in delete_entity_attributes #29

Open bknisbac opened 5 years ago

bknisbac commented 5 years ago

Hi, When running e.g. delete_sample_attributes with dry_run=True, the current logic within delete_entity_attributes dictates that dry_run mode is active only if delete_files=True.

I think it would be more intuitive and prevent accidentally deleting attributes if in such a case a message of the to-be-deleted attributes would be printed without actually deleting them from the data model.

Thank you for dalmatian - it's super useful! Binyamin

bknisbac commented 5 years ago

The case I was alluding to is dry_run=True and delete_files=False