search

getzola / zola

A fast static site generator in a single binary with everything built-in. https://www.getzola.org
https://www.getzola.org
MIT License
13.43k stars 941 forks source link

Add completion files back to repository #2105

Open barnumbirr opened 1 year ago

barnumbirr commented 1 year ago

Hi,

I maintain the unofficial zola Debian package and was wondering if it would be possible to continue generating completion files for zola. Said files were deleted when the completion subcommand was added in #1968 however this makes the Debian package build fail with the following:

install -Dm0644 "completions/zola.bash" "debian/zola/usr/share/bash-completion/completions/zola"
install: cannot stat 'completions/zola.bash': No such file or directory

Adding the files back to the zola repository is trivial and would mean each upstream maintainers won't have to generate the files on their own.

Thanks.

Keats commented 1 year ago

The completions files had been out of date for years. You can run zola completion <shell> to generate them for the shell of choice and those will be always up to date.

barnumbirr commented 1 year ago

I did understand how to generate completion files myself, I was just wondering if those files could be generated by zola's CI. This way, they're readily available to everyone and don't have to be regenerated by each package maintainer.

As an example, I also maintain an unofficial alacritty Debian package where the completion files are made available under extra/completions/.

Keats commented 1 year ago

If someone makes a PR adding that to CI sure. I had the opposite issues when I was maintaining zola-bin on AUR and I couldn't get those files in :/