getzola / zola

A fast static site generator in a single binary with everything built-in. https://www.getzola.org

https://www.getzola.org

MIT License

13.63k stars 952 forks source link

Slugify of german umlaute (ä, ö, ü) #2479

Open trembel opened 6 months ago

trembel commented 6 months ago

Bug Report

When slugifying german umlaute, the results are not consistent:.

Environment

Zola version: 0.18.0

Expected Behavior

All should be slugified the same way. In general, the umlauts should be slugged to ä -> ae ö -> oe ü -> ue

Current Behavior

Slugifying the german umlauts results in ä -> ae ö -> o ü -> untested

Keats commented 5 months ago

That would be an upstream issue: https://github.com/Stebalien/slug-rs

float3 commented 5 months ago

i'm confused about this, looking up a common definition for slugification it says "slugification turns a text into one long word containing nothing but lower case ASCII characters and hyphens" german umlauts are ASCII characters, is this definition wrong? could zola add more slugification strategies, like once that keeps CnJpKr chars for example?

Raymi306 commented 5 months ago

It looks like it is upstream of the upstream: https://github.com/kornelski/deunicode/issues/15

The gist of it is, is that those characters are not unique to German, and are being handled in a more universal way.

@float3 you are thinking of one of the extended ASCIIs.

I imagine a custom mapping file could be made for slugification for Zola...specify the name of the file in the config, drop it in to static folder?