search

geut / chan

A Changelog CLI based on http://keepachangelog.com/
ISC License
87 stars 10 forks source link

Error occurs when attempting to create a release when not using GitHub #36

Closed JacobDB closed 5 years ago

JacobDB commented 5 years ago

My company uses a self-hosted GitLab server to store our code. When I have my origin set to a repository on our GitLab server, I get the following error when runing chan release ${npm_package_version}:

[chan] [release] › ✖  error     TypeError: Cannot destructure property `template` of 'undefined' or 'null'.
JacobDB commented 5 years ago

I'm thinking this is likely an issue with packages/git-url-parse/index.js, as that's where it's trying to convert the URL, and it only has keys defined for github, bitbucket, and gitlab. It seems like even if a template is set in package.json it's still running this code, and therefore erroring.

JacobDB commented 5 years ago

This also appears to affect repositories with origin set to a GitHub URL when my custom GitLab URL is set in either .chanrc or package.json.

dpaez commented 5 years ago

Hey @JacobDB thanks for all the insights and debugging efforts! They are super helpful.

We will give it a look.

tinchoz49 commented 5 years ago

Hi @JacobDB we fixed in the release v2.1.0

JacobDB commented 5 years ago

Beautiful, seems to be working for me. Excited to finally give this a shot 🙂

tinchoz49 commented 5 years ago

As always, thank you so much for your feedback.