search

geut / mithril-transition

A lightweight library for MithrilJS to create your own custom transitions based on the lifecycle of your components.
https://geut.github.io/mithril-transition/
MIT License
39 stars 4 forks source link

Firefox doesn't support insertAdjacentElement() #2

Closed leftiness closed 8 years ago

leftiness commented 8 years ago

Source

parentNode
  .insertAdjacentElement('beforeend', lastElem);

link

Problem

insertAdjacentElement() is apparently something that Mozilla doesn't like.

link link

Solution?

All browsers apparently like insertBefore(). What do you think?

link link link

tinchoz49 commented 8 years ago

hi @leftiness ! thanks for your report. I replace it with insertAdjacentHTML since has a good perfomance.

Please, test the fix and let me know if everthing is ok.

leftiness commented 8 years ago

@tinchoz49 The fix is confirmed. While testing that, I thought that I'd try it out in other browsers, too. I'll open another issue.

tinchoz49 commented 8 years ago

ahh ok thanks!