Replication status 0% upon full replication?

geut / permanent-seeder

A super seeder for hyperdrives. By GEUT.

MIT License

26 stars 3 forks source link

Replication status 0% upon full replication? #102

Closed chartgerink closed 3 years ago

chartgerink commented 3 years ago

While debugging the Hypergraph application, @juliangruber and I stumbled upon something in the permanent seeder.

Specifically, where the Hyperdrive was replicated (only containing an index.json) but the replication state was at 0%. It seemed like the replication was instead at 100%.

This line calculates the download percentage, and we wondered whether the 0% might be an artifact because there are 0 blocks? Here, 0 / (0 || 1) = 0% but in this scenario it could be seen as a complete replication?

This is not a crucial issue; wanted to note it for tracking.

estebanprimost commented 3 years ago

Hi @chartgerink! thanks for your comment.

Situation 1: downloadedBlocks = 0 AND sizeBlocks = 0: no way to show some value. This shouldn't happen anyways.
Situation 2: downloadedBlocks = 0 OR sizeBlocks = 0: here we can use the only value present to show 100% download.

Makes sense?

btw, how do you know that is fully replicated? Do you see some other value around or it's just a file system check?

juliangruber commented 3 years ago

btw, how do you know that is fully replicated? Do you see some other value around or it's just a file system check?

We looked at the index.json metadata, which was up to data, but at the same time index.json wasn't shown as a file and it was at 0%, although everything had already been downloaded

dpaez commented 3 years ago

this should be fixed with #130