Closed galadrielbriere closed 5 years ago
Thanks for raising this issue. I did not write the code you reference but I will comment to the author that the use of bare numerical indexing such as MET_aberrations[,1] is prone to questioning -- it is much better to use the colnames. Then we see immediately that
MET_aberrations[,"Hypo-methylated"] <- rowSums(MET_matrix>0)/ncol(MET_matrix)
and conclude that the event MET_matrix>0
must associate with hypomethylation ... is that right?
Yes, but shouldn't hypomethylation be associated with MET_matrix<0
?
That is for the authors to answer and I hope they will do so soon :)
Hi @galadrielbriere and @vjcitn, thanks so much for your suggestions! We just updated the code accordingly in the master branch - both directionality and labeling the MET/CNV states instead of numerical indexing. Thanks much & let us know if you have any further suggestions!
I will, thank you for your answer !
We, therefore, close the issue! Thanks :)
Hello, I'm trying to run AMARETTO, and I found something that seems odd to me reading the code (amaretto_initialize.R).
I'm not used to manipulate methylation and copy number data, but I thought it would be :
and
Am I misunderstanding the data ?
Thank you in advance !