gever / bwx-adventure

A simple module for writing text adventure games in python.
MIT License
70 stars 30 forks source link

Needs to work in Trinket.io #8

Open gever opened 9 years ago

gever commented 9 years ago

Our code base is now working in Trinket.io because some of the reflection infrastructure is missing.

royseto commented 9 years ago

FYI, I wrote to the Trinket.io folks (in the help within their app) asking for help with this.

me:

I would like to provide a custom Python package (on GitHub) that my students can import in their trinkets. Is this currently possible?

trinket:

Hey Roy. We're currently working on this feature, though you'll have to copy and paste the module code and we'll only support one file to start. Could you share the link to the code? We'll use if for testing and let you know when the feature is ready. Elliott

me:

Hey Elliott, The module (under development) is here. https://github.com/gever/bwx-adventure It looks like someone on our side has tried to get it working in Trinket already and found some things that we needed to adjust. Please let us know if you have any advice on this: https://github.com/gever/bwx-adventure/issues/8 Thanks! Roy

royseto commented 9 years ago

This is a lot farther along now. Trinket is working on supporting importable modules. From Gever's email:

On Dec 23, 2014, at 5:11 PM, Gever wrote:

The team at Trinket have been very responsive to our bug reports and requests. The latest result is that they have fixed raw_input() to be in-line now and our adventure code is much more playable: https://trinket.io/python/cf8d6e0cd7

They are working on supporting importable modules and they think it will be ready by the time school starts.

mcapraro commented 9 years ago

this is awesome!

Michelangelo Capraro Creative Director, Digital + Interactive

LinkedIn: http://www.linkedin.com/in/michelangelo http://www.linkedin.com/in/michelangelo My Portfolio: http://mcapraro.com http://mcapraro.com/ My Apps for Kids: http://kidoodleapps.com/ http://kidoodleapps.com/

On Dec 28, 2014, at 8:13 PM, Roy Seto notifications@github.com wrote:

This is a lot farther along now. Trinket is working on supporting importable modules. From Gever's email:

On Dec 23, 2014, at 5:11 PM, Gever wrote:

The team at Trinket have been very responsive to our bug reports and requests. The latest result is that they have fixed raw_input() to be in-line now and our adventure code is much more playable: https://trinket.io/python/cf8d6e0cd7 https://trinket.io/python/cf8d6e0cd7 They are working on supporting importable modules and they think it will be ready by the time school starts.

— Reply to this email directly or view it on GitHub https://github.com/gever/bwx-adventure/issues/8#issuecomment-68231343.

eah13 commented 9 years ago

Hey guys. Love what you're doing! Just wanted to let you know we're working on teaching Trinkets how to handle multiple files, which should close this issue and let your import advent or etc. ETA <2 weeks, hopefully <1. Sorry for the delay but there are a decent amount of moving parts to this one.

Thanks for building neat stuff and let me know how else I can help! @gever and @royseto: y'all have been awesome with the bug reports/feature requests. :+1: :boom: :beers:

royseto commented 9 years ago

Thank you for all your help with our Trinket questions, @eah13 !

gever commented 9 years ago

That's awesome Elliot! As you can see from the latest check-ins, our "simple" adventure module has grown to almost 1200 lines... and showing no sign of slowing down. Being able to just import it is really going to help our young programmers. Thanks for the update!

On Fri, Jan 2, 2015 at 3:31 PM, Roy Seto notifications@github.com wrote:

Thank you for all your help with our Trinket questions, @eah13 https://github.com/eah13 !

— Reply to this email directly or view it on GitHub https://github.com/gever/bwx-adventure/issues/8#issuecomment-68572976.

Gever Tulley, Founder, Education Architect Brightworks: An Extraordinary School Tinkering School: Think, Make, Tinker (415) 701-8700 | sfbrightworks.org | cell: (415) 218-0812

gever commented 9 years ago

It's working! Check out the latest build (from @jplevyak via google docs) here: https://trinket.io/python/91d2f375a9

I've tightened up/simplifying the example code a bit, because I'm meeting with the Orange band in a little while (mostly working on their maps this morning) but wanted to be sure to have something to show them.

royseto commented 9 years ago

Awesome!

On Mon, Jan 5, 2015 at 9:16 AM, Gever Tulley notifications@github.com wrote:

It's working! Check out the latest build (from @jplevyak https://github.com/jplevyak via google docs) here: https://trinket.io/python/91d2f375a9

I've tightened up/simplifying the example code a bit, because I'm meeting with the Orange band in a little while (mostly working on their maps this morning) but wanted to be sure to have something to show them.

— Reply to this email directly or view it on GitHub https://github.com/gever/bwx-adventure/issues/8#issuecomment-68740868.

eah13 commented 9 years ago

Super excited about this... almost ready to release screenshot 2015-01-08 at 10 22 27 am

mcapraro commented 9 years ago

ooooh, cant wait!

Michelangelo Capraro Creative Director, Digital + Interactive

LinkedIn: http://www.linkedin.com/in/michelangelo http://www.linkedin.com/in/michelangelo My Portfolio: http://mcapraro.com http://mcapraro.com/ My Apps for Kids: http://kidoodleapps.com/ http://kidoodleapps.com/

On Jan 8, 2015, at 10:23 AM, Elliott Hauser notifications@github.com wrote:

Super excited about this... almost ready to release https://cloud.githubusercontent.com/assets/1702745/5667913/510bb1c2-9720-11e4-8006-062dd42c0d1d.png — Reply to this email directly or view it on GitHub https://github.com/gever/bwx-adventure/issues/8#issuecomment-69224004.

eah13 commented 9 years ago

:boom:

Have fun, y'all!

https://trinket.io/python/5c5e7d49a4

mcapraro commented 9 years ago

that is awesome

Michelangelo Capraro Creative Director, Digital + Interactive

LinkedIn: http://www.linkedin.com/in/michelangelo http://www.linkedin.com/in/michelangelo My Portfolio: http://mcapraro.com http://mcapraro.com/ My Apps for Kids: http://kidoodleapps.com/ http://kidoodleapps.com/

On Jan 10, 2015, at 8:46 AM, Elliott Hauser notifications@github.com wrote:

Have fun, y'all!

https://trinket.io/python/5c5e7d49a4 https://trinket.io/python/5c5e7d49a4 — Reply to this email directly or view it on GitHub https://github.com/gever/bwx-adventure/issues/8#issuecomment-69427022.

eah13 commented 9 years ago

Erp...Just realized that skulpt doesn't have textwrap, argparse, or urllib2 implemented. Might need to split this issue apart and tackle those. We may be able to implement some of these, and textwrap we can just add into skulpt verbatim...Reopening for now. Got a little too excited

Sources for:

walnerz commented 9 years ago

Thanks Elliot! don't worry about argparse, it won't be relevant in th etrinket environment and I am going to move it out to another module that is conditionally loaded.

walnerz commented 9 years ago

argparse is now moved out into the optional advent_devtools module as of commit e62e735