search

gevhaz / hugo-theme-notrack

A libre hugo personal webpage theme without reliance on third parties and no tracking.
GNU General Public License v3.0
39 stars 28 forks source link

Convert SCSS to ordinary CSS #38

Open gevhaz opened 1 day ago

gevhaz commented 1 day ago

"Nested CSS" is now a thing: https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting/Using_CSS_nesting

I don't think styles.scss uses any SASS functionality other than the nesting, so it should be possible to turn it into regular natively supported CSS, which would eliminate the need for pre-processing.

DatHoang102003 commented 1 day ago

Hi, I have some experience with CSS and a bit of knowledge in SCSS. You can assign this to me, and I'll do my best to assist.

gevhaz commented 1 day ago

Awesome, I'm happy to accept the help. You've been assigned.

I don't have any specific coding guidelines, but for smooth review:

  1. Don't make the diff larger than necessary.
  2. Keep the style consistent (like always one empty line between blocks).
  3. If you need to do something categorically different from 'translating SCSS to CSS', separate commits might be good. I'll leave it to your judgment.
  4. Please also post here how you validate that your change produces the same result as before. I'm not entirely sure how to do this.
  5. If any cleanup is necessary, include that also. I think the Dependencies section of the readme might be outdated now, since the +extended requirement was for pre-processing the SCSS (#29). On the other hand, the theme doesn't work with version lower than 0.120.0 (#30). So remove +extended and set 0.120.0 as the new minimum version.

Let me know if you run into any issues.