search

gexijin / idepGolem

16 stars 11 forks source link

allow string numbers to be read in as #569

Closed EricTulowetzke closed 11 months ago

EricTulowetzke commented 11 months ago

now able to read "1,120" strings as numbers. I did this for csv and tab format to keep the workflow the same.

This fixes #554 issue, BUT I have a questions

If a cell has NA how do we want to handle it?

suggestion:

We remove the Gene(row) and inform the user that a Cell had NA value and that Row was removed

EricTulowetzke commented 11 months ago

RNASeq.Read.count.data-iDEP_with_NA_value.csv

This file has a cell with "mike" in it which will cause NA for the row at that sample.

I know this seems weird but Excel likes to format numbers weirdly sometimes and we need to come up with edge cases and do data validation for all possible use cases

EricTulowetzke commented 11 months ago

@gexijin I have added table to show the user what rows get removed when a value can't be read as a number and shows up as NA. In this thread I have added a file with one word in the file.

gexijin commented 11 months ago

If a row has all NA, then we can remove these.