search

geysertimes / geysertimes-r-package

R package for accessing and analyzing the GeyserTimes database
Other
2 stars 4 forks source link

Geyser locations #12

Closed spkaluzny closed 4 years ago

spkaluzny commented 4 years ago

New version (0.0.0.9005) with gt_get_data function that downloads both the latest eruption data (from https://geysertimes.org/archive/complete/*.tsv.gz) and the geyser locations data (from https://www.geysertimes.org/api/v5/geysers). The gt_load_data function is split into gt_load_eruptions (what gt_load_data used to do) and gt_load_geysers which loads the geyser location data. Help files and vignette updated as appropriate to use the new functions.

taltstidl commented 4 years ago

@spkaluzny Looks good to me. Well written and well documented, thank you for your contribution. Also, good catch with the switched time_updated and time_entered columns! Edit: I've updated the README to use the new gt_load_eruptions function and also added a missing underscore in man/gt_load_data.Rd.