search

gf-dcc / data-model

Gray Foundation data model
https://gf-dcc.github.io/data-model/
2 stars 0 forks source link

Patch/issue 75 #76

Closed anngvu closed 10 months ago

anngvu commented 10 months ago

Fixes #75; there were actually two things going on that were good to catch:

  1. CONFIG in test file was not pointing to the DCA staging config, so even when config was updated there, running test-generate would have ignored re-rendering template.
  2. This one's a little tricky, but good to be aware of: So can see a block for "Dead" component removed here https://github.com/gf-dcc/data-model/compare/patch/issue-75?expand=1#diff-74bb61d0c141447a8ff6ff5097fad1de065f061a7e4979bfc887a8e617e9b6ffL274. The way this works is that "Dead" is a potential selection for "Vital Status" field. So this will pull in all the things under the "Dead" component as extra columns. I personally don't like how this works because it's kind of weird/not super clear behavior. It shouldn't have been a component and something we should have cleaned up.
github-actions[bot] commented 10 months ago

Test Suite Report

Template Generation

template result link
CohortCoreTemplate :smile: template link
ImagingLevel2 :smile: template link
ImagingLevel2Channels :smile: template link
ScATAC-seqLevel1 :smile: template link
ScRNA-seqLevel1 :smile: template link
ScRNA-seqLevel2 :smile: template link
ScRNA-seqLevel3 :smile: template link
ScRNA-seqLevel4 :smile: template link

Manifest Validation

TODO