search

gf-dcc / data-model

Gray Foundation data model
https://gf-dcc.github.io/data-model/
2 stars 0 forks source link

Update age validation #83

Closed anngvu closed 7 months ago

anngvu commented 7 months ago

Hmm, so we want to keep age required so that's still emphasized in data collection, but required does not accept blanks. So this changes validation to use regex. For truly missing data, we will want contributors to be explicit, so let's only accept "unknown" (or another possible value is "Not Reported").

Helpful reference: https://sagebionetworks.jira.com/wiki/spaces/SCHEM/pages/2645262364/Data+Model+Validation+Rules#Regex-Validation-Type

github-actions[bot] commented 7 months ago

Test Suite Report

Template Generation

template result link
BulkMethylation-seqLevel1 :smile: template link
BulkMethylation-seqLevel2 :smile: template link
BulkMethylation-seqLevel3 :smile: template link
CohortCoreTemplate :smile: template link
ImagingLevel2 :smile: template link
ImagingLevel2Channels :smile: template link
ScRNA-seqLevel1 :smile: template link
ScRNA-seqLevel2 :smile: template link
ScRNA-seqLevel3 :smile: template link
ScRNA-seqLevel4 :smile: template link

Manifest Validation

TODO

cconrad8 commented 7 months ago

@anngvu it looks good to me!

we could change the other ages in a different PR too. as well as add more validation rules