search

gf3 / IRC-js

The best IRC library for node.js
http://irc-js.com
The Unlicense
179 stars 33 forks source link

'coloured-log' shouldn't be a bundled dependency... #27

Closed TooTallNate closed 13 years ago

TooTallNate commented 13 years ago

PanPG is ok since it's not already published on npm, but coloured-log needs to go. It can be installed from npm fine, and on top of that, the irc-js version that's currently up on npm has an incomplete checkout of 'coloured-log', it's dependencies aren't checked out. This leads to npm saying that irc-js is missing dependencies immediately after installation.

Just remove this line and rm -rf node_modules/coloured-log and republish on npm and we should be good! Thanks in advance!

gf3 commented 13 years ago

Indeed, I am going to be removing all (unnecessary) bundled dependencies from both Jerk and IRC-js soon. This was originally done to allow people to simply clone the repo and start using it, but now that npm has become ubiquitous I feel it is safe remove these deps.

broofa commented 13 years ago

Nice! Yeah, I found those dependencies to be a bit annoying.

TooTallNate commented 13 years ago

See #32 for a pull request that fixes this...

gf3 commented 13 years ago

Fixed in #32