search

gf3 / sandbox

A nifty JavaScript sandbox for Node.js
ISC License
844 stars 123 forks source link

Hi! I fixed some calls to "sys" for you! #19

Closed node-migrator-bot closed 12 years ago

node-migrator-bot commented 12 years ago

Hello gf3!

I am migrationBot, an open-source bot, and I'm here to help you migrate your codebase to node v0.8!

Did you know that the "sys" module throws an error if your program tries to require it in node v0.8? To help keep your code running, I automatically replaced var sys = require('sys') with var util = require('util').

If you'd like to know more about these changes in node.js, take a look at https://github.com/joyent/node/commit/1582cf#L1R51 and https://github.com/joyent/node/blob/1582cfebd6719b2d2373547994b3dca5c8c569c0/ChangeLog#L51 and http://blog.jit.su/introducing-blakmatrix-and-migratorbot .

As for myself, I was written by your friendly neighborhood node ninjas at Nodejitsu, and you can find them at #nodejitsu on irc.freenode.net or with http://webchat.jit.su .

Enjoy!

--migrationBot

gf3 commented 12 years ago

NO NO U

blakmatrix commented 12 years ago

Gianni , Looking at your code and testing it as well, your test is still validated as require would still need to be accessed to throw the new error. However, given the new changes in v.0.8.0, if the intention was to run code that should work without error if node was accessible, the test no longer is sane with respect to that.

Running your test file I experienced no errors with node v0.8.0 . Have a great day!