search

gfa-cc-after / Pet-Clinic-GilmoreDevs

Pet clinic project made by group 2
https://frontend-production-e146.up.railway.app/
GNU General Public License v3.0
2 stars 0 forks source link

chore: resend token when update user #69

Closed Hsbalazs closed 1 month ago

Hsbalazs commented 1 month ago

@markkovari There is a threshold value added to vite.config.ts at last merging. Why do we use this thing? Can we set to different value? For me it seems we have problem with it now.

markkovari commented 1 month ago

@Hsbalazs yes we have some "issues" with it. This is a threshold to prevent our code to be merged without code coverage. This will enforce us to write tests too. This is not a silver bullet, code coverage might be snake oil, but we need to develop a habit to write more tests or write at least more testable code.

markkovari commented 1 month ago

@Hsbalazs going to close this one, the changes from here already have been merged.