gfanto / fzf-lsp.nvim

Enable the power of fzf fuzzy search for the neovim built in lsp
MIT License
223 stars 11 forks source link

Prettier formatting #30

Closed mhanberg closed 2 years ago

mhanberg commented 2 years ago

Description

Fixes #29

Notes

gfanto commented 2 years ago

Thanks for the PR, i look at it and looks good to me, the only thing i would like to have it's an option to enable/disable the "prittier formatting", what you think about that?

mhanberg commented 2 years ago

I don't think a "enable/disable" is a good config opt to add, but another avenue could be to allow the user to provide a function to customize the formatting to whatever they want.

mhanberg commented 2 years ago

And could also expose two functions, the one that this PR implements and a "plain" one that retains the old behavior.

gfanto commented 2 years ago

Yeah sounds good, i was thinking on a "fast" change to merge the PR. I think we can merge this PR and see if someone complain for the change on formatting (i don't think it will happen, but this was my reason on asking you the option stuff), then in case we can make the changes to have both the old and the new behavior.

mhanberg commented 2 years ago

Thank you! Feel free to merge 👍.

mhanberg commented 2 years ago

@gfanto probably need to update the gif in the readme now 😄 .

gfanto commented 2 years ago

Good point! :joy: I've updated it right now :v:

aljoscha commented 2 years ago

Just noticed this after updating my packages. Could we add an option for getting back the file path? I find it very helpful to know what file references are coming from, for example for :References.

mhanberg commented 2 years ago

@aljoscha I opened a proposal for this that I'll get to implementing soon (given we reach a decision on the right direction) #31

gfanto commented 2 years ago

@aljoscha @mhanberg I've made a fast fix now with a new option to allow you to enable/disable the "pretty formatting" The default is set to the old version and to enable the "pretty formatting" you have to add the configuration let g:fzf_lsp_pretty = v:true

aljoscha commented 2 years ago

Thanks a lot for the prompt response to this! :blush: