gfanto / fzf-lsp.nvim

Enable the power of fzf fuzzy search for the neovim built in lsp
MIT License
223 stars 11 forks source link

looks link fzf-lsp doesn't respect g:fzf_preview_window settting #5

Closed isvicy closed 3 years ago

isvicy commented 3 years ago

nvim version:

NVIM v0.5.0-dev+967-g7afd4526f
Build type: Release
LuaJIT 2.1.0-beta3

I got this fzf preview settings in my config: let g:fzf_preview_window = ['up:40%', 'ctrl-/'], which makes the preview window in the top section of float window.

this is the screenshot when i find a file using fzf.vim, which works as expected: image

and this is the screenshot when i find references using fzf-lsp: image

How can I make fzf-lsp respects g:fzf_xxx settings?

gfanto commented 3 years ago

The problem is that i'm working with just the minimum fzf plugin end not with fzf.vim right now so i do not respect the fzf_preview_window settings, but i can make a fix adding the support with no problems, and in short amount of time. Now i'm a little bit busy, but i think in few hours from now i'll make the update.

Thank for reporting this, i will never found that, because i usually use the default settings for the window preview

gfanto commented 3 years ago

Ok, as i promised you i added the support to the preview window settings. Run :PlugUpdate and should work with your standard configuration. If you want to have different settings from your default fzf settings (for example i like having symbols to the bottom and files in the center window) just use the g:fzf_lsp_preview_window global variable.

isvicy commented 3 years ago

Things works as expected now! Thx for your help.