orderbook without parameters invokes API call with limit_bids and limit_asks

[dutu]

when orderbook method is called without the optional parameters, the native API is called with limit_bids=50&limit_asks=50. https://github.com/gferrin/bitfinex/blob/master/src/bitfinex.coffee#L103

[gferrin]

These are the defaults, now they accept optional parameters.

[dutu]

same as commented on #12. perhaps you can just include these parameters if they are specified, else call the native API without parameter and the bitfinex will respond with the defaults with whatever default values are. With this suggestion you can also avoid updating your wrapper code in case bitfinex changes the default value.

[gferrin]

Yeah good point. Here's what the function looks like now:

orderbook: (symbol, options, cb) ->

        allowed_options = ['limit_bids', 'limit_asks', 'group']
        query_string = '/?'
        index = 0
        uri = 'book/' + symbol 

        if typeof options is 'function'
            cb = options
        else 
            try 
                for option, value of options
                    if option in allowed_options
                        if index++ > 1
                            query_string += '&' + option + '=' + value
                        else
                            query_string += option + '=' + value

                if index > 0 
                    uri += query_string
            catch err
                return cb(err)

        @make_public_request(uri, cb)

[dutu]

yes, it's ok, maybe a bit complicated? :). Perhaps as wrapper function it should pass the parameters/options it receives (i.e. no checking/setting default values and not even if the options are allowed or not). Perhaps you could build the query_string by just going through the options keys.

[dutu]

also when there are no options should query_string be "" rather than '/?'?

[dutu]

by not checking allowed_options, you can also avoid code changes in case Bitfinex is changing the possible options for some reason.

[gferrin]

query_string only gets added when index > 0 but I could move it. And yeah that's true about the allowed_options I'll remove the check.

[gferrin]

Here's the new version

orderbook: (symbol, options, cb) ->

        index = 0
        uri = 'book/' + symbol 

        if typeof options is 'function'
            cb = options
        else 
            try 
                for option, value of options
                    if index++ > 1
                        query_string += '&' + option + '=' + value
                    else
                        query_string = '/?' + option + '=' + value

                if index > 0 
                    uri += query_string
            catch err
                return cb(err)

        @make_public_request(uri, cb)

[dutu]

thanks a lot. Really appreciated