search

gfilicetti / gke-github-deployment

This repository is a full example of a full CI/CD pipeline using Github actions, terraform and other tech.
Apache License 2.0
3 stars 1 forks source link

Move bq from tf to scripts #97

Closed chandinipenmetsa closed 2 weeks ago

chandinipenmetsa commented 3 weeks ago

Created setup-bq.sh under scripts to create bq datasets, tables, scheduled queries, log sinks, relevant iam policy bindings Commented out bq.tf, logs.tf, relevant roles from iam.tf

gfilicetti commented 2 weeks ago

In general -

Need to delete TF code rather than comment out. Can always dig up the commit history if necessary.

Overall I think the script is an improvement. I do still think having this in Jupyter notebook type setup would be preferred method for Anayltic folks

We should talk about this because my immediate reaction is a hard NO to introducing Notebooks only for set up reasons.

mbychkowski commented 2 weeks ago

In general - Need to delete TF code rather than comment out. Can always dig up the commit history if necessary. Overall I think the script is an improvement. I do still think having this in Jupyter notebook type setup would be preferred method for Anayltic folks

We should talk about this because my immediate reaction is a hard NO to introducing Notebooks only for set up reasons.

Sounds good. I think scripts are good for now than. can discuss more on the notebooks or other methods as we go along