search

gfleury / go-bitbucket-v1

Bitbucket-server API (v1.0) library for Golang.
MIT License
50 stars 50 forks source link

does webhook secret validation work? #71

Closed tooptoop4 closed 1 year ago

tooptoop4 commented 2 years ago

https://github.com/argoproj/argo-events/blob/340627059538af49f095e497fdef1b9e888f393d/eventsources/sources/bitbucketserver/start.go#L290 references this lib but curl requests to the webook still succeed without any webhook secret passed

i couldn't see something like https://github.com/go-playground/webhooks/blob/v5.17.0/bitbucket-server/bitbucketserver.go#L129-L141

tooptoop4 commented 1 year ago

doesn't work

gfleury commented 1 year ago

Hey @tooptoop4 some endpoints are indeed missing some details. Not sure if this is one of them.