search

gflohr / libintl-perl

Official repository for libintl-perl
http://www.guido-flohr.net/en/projects/#libintl-perl
GNU General Public License v3.0
5 stars 4 forks source link

Text::LocaleDomain 1.32' __find_domain() Errors on Windows #7

Closed theory closed 1 year ago

theory commented 3 years ago

Looks like it was broken in 8c2b356, where I guess abs_path barfs when $found_dir is undef. For example, in this Sqitch test failure, it chokes on this bit of Cwd in Perl 5.16. Here's the stack trace:

# No such file or directory at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/site/lib/Locale/TextDomain.pm line 415.
#  at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/lib/Cwd.pm line 354.
#   Cwd::_croak() called at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/lib/Cwd.pm line 630
#   Cwd::fast_abs_path() called at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/site/lib/Locale/TextDomain.pm line 415
#   Locale::TextDomain::__find_domain() called at C:/hostedtoolcache/windows/perl/5.16.3-thr/x64/site/lib/Locale/TextDomain.pm line 211
#   Locale::TextDomain::__x() called at D:\a\sqitch\sqitch\lib/App/Sqitch/Command/add.pm line 224
#   App::Sqitch::Command::add::configure() called at D:\a\sqitch\sqitch\lib/App/Sqitch/Role/ContextCommand.pm line 49
#   App::Sqitch::Role::ContextCommand::__ANON__() called at (eval 341) line 1
#   App::Sqitch::Command::add::__ANON__() called at (eval 343) line 2
#   App::Sqitch::Command::add::configure() called at ./t/add.t line 144
#   Test::Exception::throws_ok() called at ./t/add.t line 145
Montclair commented 1 year ago

I have this issue as well.

gflohr commented 1 year ago

Does 3a0ab71 fix the problem?

Montclair commented 1 year ago

It does for me, thanks! Please push to cpan.

gflohr commented 1 year ago

Fixed with 3a0ab71. Thanks for testing!