search

gflze / GFLBans

Ban Management system for GFL
https://bans.gflclan.com/
GNU General Public License v3.0
1 stars 1 forks source link

Webhook ion server settings #18

Open JMorell opened 3 hours ago

JMorell commented 3 hours ago

Every time I go back to edit the server settings, the webhook fields are empty.

image

Vauff commented 2 hours ago

image

Frozen-H2O commented 2 hours ago

I guess I should indicate on that page if there is some webhook saved in the database (ie. just showing dots like a censored password), but the web hooks themselves are intentionally not displayed to prevent leaks.

JMorell commented 2 hours ago

Is that it is not clear if I click on save, the saved webhooks will be lost, nor do I know how to delete it completely.

And the Pingable Staff field, I need to add the webhook everytime I wan to change the last field?

Frozen-H2O commented 2 hours ago

Currently, if you just click save with the webhook fields empty, it shouldn't overwrite what is already saved (which in turn means currently the only way to delete the webhooks is filling in the field with garbage). When I change it to be a censored version, I'll also change it so deleting the placeholder will actually clear the webhook, while if you don't delete the placeholder nothing will be edited. Hopefully that should be a bit more intuitive.

As for the pingable staff role, as long as the client can get some feedback a webhook is already saved, I'll let that be edited without requiring the webhook to be re-inputted. However, currently it does require the webhook to be saved again, yes.