search

gfngfn / SATySFi

A statically-typed, functional typesetting system
GNU Lesser General Public License v3.0
1.16k stars 82 forks source link

Use opam repo instead of submodules #14

Closed objmagic closed 6 years ago

objmagic commented 6 years ago

See: https://github.com/ocamllabs/advanced-fp-repo

A customized repo can be set up to have your customized camlpdf, otfm, and ucorelib there.

I can send some pull requests when I'm free.

nekketsuuu commented 6 years ago

@gfngfn Will you plan to send pull requests of your custom packages? If not, I also think creating a opam repo is a good idea to divide the dependency problem and to simplify the build process. But it needs a new official git repo, so now I can't contribute to this.

cf.: https://opam.ocaml.org/doc/Usage.html#opam-repo

objmagic commented 6 years ago

@nekketsuuu you can create a opam repo, test it, and transfer ownership back to gfn on GitHub. Or better, we can set up an organization on GitHub.

nekketsuuu commented 6 years ago

@objmagic Thanks! I don't know we can transfer repo's ownership.

nekketsuuu commented 6 years ago

I tried to set up a opam repo for SATySFi. It seems to be working well :) https://github.com/nekketsuuu/satysfi-external-repo

nekketsuuu commented 6 years ago

@gfngfn Which do you think is better, to transfer ownership or to make an organization?

qnighy commented 6 years ago

So in my understanding, the possible options are:

  1. Keep status quo.
  2. Create a custom opam repo.
  3. Try to push everything back to the upstreams, then use the official package.

We can also try to push some of the patches back to the upstreams, while choosing 1 and 2.

@gfngfn which option do you think is ideal? My idea is that if these patches are highly SATySFi-specific, then 2 is suitable. I'm willing to help you either way.

gfngfn commented 6 years ago

Thank you for the suggestion, and I’m terribly sorry for the late response.

For now, I would not like to send gfngfn/otfm:master to dbuenzli/otfm as a pull request, since the development of gfngfn/otfm largely breaks the backward compatibility with dbuenzli/otfm. If willing to do so, it seems necessary to have a profound discussion and to reach a genuine consensus with dbuenzli-san.

nekketsuuu commented 6 years ago

I transferred the ownership of nekketsuuu/satysfi-external-repo to gfngfn.

nekketsuuu commented 6 years ago

@objmagic #62 is merged thanks to gfn-san :-)

gfngfn commented 6 years ago

Thank you very much for introducing external opam repositories (and am very sorry for the late response).

objmagic commented 6 years ago

Great. Thanks!

On Mon, Apr 2, 2018 at 5:30 AM, Takuma Ishikawa notifications@github.com wrote:

@objmagic https://github.com/objmagic #62 https://github.com/gfngfn/SATySFi/pull/62 is merged thanks to gfn-san :-)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gfngfn/SATySFi/issues/14#issuecomment-377919636, or mute the thread https://github.com/notifications/unsubscribe-auth/ADfJj3bIitmxrzpB_Qax7jcnYFFJhcBLks5tkhnMgaJpZM4SAUqv .

objmagic commented 6 years ago

closed via #62