search

gfngfn / SATySFi

A statically-typed, functional typesetting system
GNU Lesser General Public License v3.0
1.16k stars 82 forks source link

Missing dependency of uchar #23

Closed nekketsuuu closed 6 years ago

nekketsuuu commented 6 years ago

I noticed that a package uchar is not written in opam whereas it's needed for the external package otfm (ref). Also, a constraint "uutf" {>= "1.0.0"} is missing.

Although uchar is unnecessary for OCaml >= 4.03, this should be written in opam. Or, using opam repo (#14) will help.

objmagic commented 6 years ago

Although uchar is unnecessary for OCaml >= 4.03

why is that?

nekketsuuu commented 6 years ago

@objmagic I think uchar is a compatibility library for OCaml < 4.03. Sorry if I misunderstood.

objmagic commented 6 years ago

@nekketsuuu Oh I see. you are right. But with #16, we no longer need to specify such dependency.

objmagic commented 6 years ago

can be closed via #16

nekketsuuu commented 6 years ago

Although uchar is unnecessary for OCaml 4.06.0, I don't know it's OK not to write uchar in opam. The opam file of gfngfn/otfm says it needs uchar to build, and we build gfngfn/otfm at the compile time of SATySFi. I think #14 can divide this dependency into each external library.