Fix exports: ESM & CJS multi-module - Githubissues

gfodor / p2pcf

Low cost, low effort P2P WebRTC serverless signalling using Cloudflare Workers

MIT License

952 stars 53 forks source link

Fix exports: ESM & CJS multi-module #24

Open pubkey opened 10 months ago

pubkey commented 10 months ago

This PR changes the build scripts so that this package can be used either as esm module or as cjs package at the same time.

This fixes https://github.com/gfodor/p2pcf/issues/21 while making it still usable for everyone who is still on cjs modules.

Questions:

Would you accept a PR to add a CI via github actions with some tests?
Would you accept a PR to add typescript typings (or even rewrite the code to typescript)?
Would you accept a PR to have a node.js fallback where the global window variable is not defined?