React to .NET branding update

gfoidl / Stochastics

Stochastic tools, distrubution, analysis

MIT License

3 stars 0 forks source link

React to .NET branding update #88

Open gfoidl opened 4 years ago

gfoidl commented 4 years ago

In https://github.com/gfoidl/Stochastics/blob/e9e04ccf8dbf7bdbf7b7a665e1c5b94fb45b88ac/source/gfoidl.Stochastics/RuntimeHelper.cs#L10-L19 make sure that .NET 5 will be known.

Cf. https://github.com/dotnet/runtime/issues/33680

ericstj commented 4 years ago

This actually didn't change as behind the scenes TargetFrameworkIdentifier (from which this attribute value is built) remains NETCoreApp. cc @viktorhofer

gfoidl commented 4 years ago

Thanks for the info -- I didn't notice this.

I'll leave the issue open, as reminder for me, because (now) I believe there are better ways to detect features provided by .NET Core 3 / .NET 5.