search

gforcada / haproxy_log_analysis

HAProxy log analyzer
https://pypi.org/project/haproxy_log_analysis
GNU General Public License v3.0
88 stars 35 forks source link

Adding support for journalctl dump and v6 addressing #32

Closed valleedelisle closed 4 years ago

valleedelisle commented 4 years ago

Journalctl under RHEL uses a timestamp that wasn't detected by the regex. Also, adding support for v6 addressing

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.007%) to 99.939% when pulling cf00f8014c77f4777d5aa486f3d45bedd5359673 on valleedelisle:rhel-compatible into ad76cf926a059b00d45c51e2a8af58e5baedbe3f on gforcada:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 0a823a0313f017e168b4bf49d9039542fc7a4601 on valleedelisle:rhel-compatible into 1a96e3c26ad6b7ac0e9105802ba00d62429705d2 on gforcada:master.

gforcada commented 4 years ago

@valleedelisle thanks for, another!, pull request :+1:

Would you mind adding a test to ensure the format is parsed properly and future refactorings do not miss the changes you added?

After that I can make a release with the other (already merged) pull request and this one :100:

valleedelisle commented 4 years ago

@gforcada Thanks for the merge, I appreciate it! I've added a test, but I don't have much experience with unit tests so let me know if it's enough or if there's something else I need to validate.

gforcada commented 4 years ago

Thanks for the tests!

valleedelisle commented 4 years ago

Thanks for the merge!