search

gforcada / haproxy_log_analysis

HAProxy log analyzer
https://pypi.org/project/haproxy_log_analysis
GNU General Public License v3.0
89 stars 35 forks source link

Adding support to output json instead of python dict #33

Closed valleedelisle closed 4 years ago

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 23b039ef0faff353280a10d52c0f65985c73615c on valleedelisle:json-output into 1a96e3c26ad6b7ac0e9105802ba00d62429705d2 on gforcada:master.

gforcada commented 4 years ago

@valleedelisle thanks for the pull request! the code looks good :+1:

gforcada commented 4 years ago

I was briefly testing this yesterday and noticed that the --json switch is not working as expected on at least a few occasions, counter command for example, or commands that simply output a number, they are not converted to proper json :confused:

Though it probably would mean a full rewrite of the commands to be able to do so. In which specific commands does it work as you expected to be? :thinking: We might document that on the README so as to not get blamed afterwards to have a broken switch.

gforcada commented 4 years ago

@valleedelisle I made a new release (4.0.0) with full JSON output support. You might be interested on it :)