search

gforcada / haproxy_log_analysis

HAProxy log analyzer
https://pypi.org/project/haproxy_log_analysis
GNU General Public License v3.0
89 stars 35 forks source link

Adding command requests_per_hour #34

Closed valleedelisle closed 4 years ago

valleedelisle commented 4 years ago

Refactored the time calculation function to be more dynamic

coveralls commented 4 years ago

Coverage Status

Coverage increased (+0.07%) to 100.0% when pulling d95967f6e400f48000ffe368e46a705c7180200a on valleedelisle:requests_per_hour into ad76cf926a059b00d45c51e2a8af58e5baedbe3f on gforcada:master.

gforcada commented 4 years ago

@valleedelisle thanks for the pull request! :100: I would like to get a comment on the logic of it, but otherwise it looks good! :+1:

gforcada commented 4 years ago

@valleedelisle sorry I made a new release of haproxy_log_analysis with a complete rewrite of the commands and the main logic.

Sadly this means that this pull request can no longer be merged as it is :disappointed:

On the up side, the commands now are more easier to write and perform much better :+1: I can try to recreate your additions here on a new pull request adapted to the new code base. Would it be ok with you? :thinking:

valleedelisle commented 4 years ago

@gforcada Nice! I'll look into this, thanks for maintaining this project. Honestly, I was able to achieve what I had to do and extract the stats I needed so I kind of lost interest into this for now. Feel free to take what I did and adapt it however you think it fits best.

Thanks again for the great job!

gforcada commented 4 years ago

Done at #36