search

gforcada / haproxy_log_analysis

HAProxy log analyzer
https://pypi.org/project/haproxy_log_analysis
GNU General Public License v3.0
89 stars 35 forks source link

[FIX] Remove end of line #45

Open corsojulian7 opened 3 years ago

corsojulian7 commented 3 years ago

Allow users to add custom fields to logs at the end of the line and still using haproxy_log_analysis.

Line Example adding encrypt and protocol at the end: Dec 18 13:29:38 localhost haproxy[103935]: 45.163.31.4:48486 [18/Dec/2020:13:29:38.458] xxxx~ xxxxx/xxxxx-prd 0/0/1/312/313 200 624 - - ---- 5/5/3/1/0 0/0 {172.30.2.172|604||} {Restlet-Framework/2.2.3|473|||} "POST /CustomEndpoint/Endpoint HTTP/1.1" ECDHE-RSA-AES256-SHA384 TLSv1.2

gforcada commented 3 years ago

Hi, thanks for taking your time to report issues and improvements for haproxy_log_analysis! :100:

I see that CI did not work, maybe because it is still set up to use travis and travis is closing. I will double check if tests do pass.

In general I'm fine with the change, it would be nice if you can add this specific example that you add on a test to ensure that it is parsed as valid after your changes.

Do not hesitate to ping me again if I don't reply within a few days, I'm rather busy lately, so I can easily forget about this issue. :sweat_smile:

corsojulian7 commented 3 years ago

Hi, thanks for taking your time to report issues and improvements for haproxy_log_analysis! 💯

I see that CI did not work, maybe because it is still set up to use travis and travis is closing. I will double check if tests do pass.

In general I'm fine with the change, it would be nice if you can add this specific example that you add on a test to ensure that it is parsed as valid after your changes.

Do not hesitate to ping me again if I don't reply within a few days, I'm rather busy lately, so I can easily forget about this issue. 😅

Done! Commit: #4b7556e - [ADD] Custom Logline in tests