search

gfranko / jquery.tocify.js

A jQuery Table of Contents plugin that can be themed with Twitter Bootstrap or jQueryUI.
http://gregfranko.com/jquery.tocify.js/
MIT License
928 stars 216 forks source link

ToC incorrect nesting #26

Closed buro9 closed 11 years ago

buro9 commented 11 years ago

3rd level nesting appears to be broken with the latest update.

Given the validating HTML that exists here: http://microcosm-cc.github.io/

And using Chrome v26 stable and Firefox v20 stable.

When one expands the Conventions ToC entry: http://microcosm-cc.github.io/#Conventions

The Conventions menu contains entries to /microcosms, /conversations, /events, etc... all of which exist in the API Reference section.

When one expands the API Reference ToC entry: http://microcosm-cc.github.io/#APIReference

All of the menu items render correctly.

However, when you click on /conversations http://microcosm-cc.github.io/#/conversations

The /site and /microcosms menu entries in the ToC below API Reference are removed. This is also true of each subsequent child menu in the ToC below API Reference, i.e. clicking /events removes the menu items preceding it.

The HTML shows that all of the /item links exist in the API Reference section only.

This updated version feels more broken than the prior version. Am happy to make a PayPal donation of £50 to sponsor a fix that allows the 4 level menu to work as expected (let me know your PayPal).

gfranko commented 11 years ago

I am looking into your issue and will hopefully have a fix out later today. Also, donations are always appreciated! They really help. Here is a link to my PayPal

gfranko commented 11 years ago

I just released a bunch of fixes for the v1.4.0 release, so your issues should be fixed (fingers crossed). Could you update your code to the latest code and then let me know if everything works?

buro9 commented 11 years ago

The fix works, which I appreciate a lot... so I've sent $100 (£67) to your PayPal.

There are still minor issues (like what happens when you zoom and scroll on a tablet), but as it works on desktop browsers I'm very happy. Thanks.

gfranko commented 11 years ago

@buro9 Great! Feel free to create more issues for anything else that may need to be improved. I'm always looking for ways to make Tocify better.

Also, thank you for your donation! It is always inspiring to see people like you supporting open source projects.