Closed nberger closed 9 years ago
Btw this is based on similar tests in test.check.clojure-test-test and test.check.cljs-test-test
the only thing that bothers me is needing a whitelist of "real tests" to run, since it's error-prone w.r.t. adding new tests. Could we make it a blacklist instead somehow?
Yeah, that's one downside... I'll see if I can come up with something...
But I'm very tempted to propose moving that single test to a separate namespace and simply count on "how can whitelisting one out of two tests could go wrong"? :)
yeah if it's in a special namespace it doesn't bother me as much
Cool, moved it to a separate ns.
I think the alternative would be to start playing around with ns-interns
which would be even more error-prone IMO
@gfredericks: What do you think about this PR? Is it missing something? Do you prefer to close it and wait for #15 which includes a similar change?
Is this the test that's now failing after #21?
El 23/08/2015 11:27, "Gary Fredericks" notifications@github.com escribió:
Is this the test that's now failing after #21?
Yes. It's not falling here because it's based on the code before #21.
Make it easier to understand and debug. Leave it better prepared for migration to cljs using cljc by not using
eval
which is not available in the cljs runtime