search

gfredericks / test.chuck

A utility library for test.check
Eclipse Public License 1.0
215 stars 26 forks source link

Rename gen-datetime to datetime #20

Closed nberger closed 9 years ago

nberger commented 9 years ago

Move implementation details to test.chuck.datetimes ns

Uses gen/choose instead of gen'/bounded-int in gen-datetime, to avoid a circular dependency

Fixes #19

nberger commented 9 years ago

@gfredericks, @firesofmay:

There's one gotcha here: I had to use gen/choose instead of gen'/bounded-int to avoid a circular dependency on test.chuck.generators. I'm not sure about the importance of this change. FWIW the tests run fine.

What do you think?

gfredericks commented 9 years ago

The use of bounded-int is important (see the discussion on the PR for datetime for details), so it'd be better to keep the namespaces the same for now.

nberger commented 9 years ago

Thanks, I understand the importante now.

Changed it back to just rename from gen-datetime to datetime.

gfredericks commented 9 years ago

Looks great, thanks