search

gfredericks / test.chuck

A utility library for test.check
Eclipse Public License 1.0
215 stars 26 forks source link

Set jvm-opts so build can run in circleCI #22

Closed nberger closed 9 years ago

nberger commented 9 years ago

Without this the build fails because it hits the 4GB mem limit

nberger commented 9 years ago

@gfredericks:

My proposal is to start using CircleCI as it's what I have used the most, and because it's very easy to setup. AFAIK this are the steps:

  1. Go to https://circleci.com/gh/gfredericks/test.chuck
  2. It will ask you to sign in with your github account.
  3. Click the button saying something like "Follow this project"

I think that's it, except because the build is hitting the memory limit in Circle. It seems that's because of the regex tests, but I'm not sure. Anyways, this PR fixes it by limiting the memory available to the JVM.

gfredericks commented 9 years ago

I setup circle-ci and attempted to modify the test command so that it uses a :circle-ci profile -- can you modify this PR to put the jvm-opts inside such a profile?

This way it doesn't bother any other usage and is clear what it's for.

nberger commented 9 years ago

Sounds good. Perhaps it's better to tweak the test command for circle in a circle.yml file, so it's versioned. I'll do both, let's see how it works...

nberger commented 9 years ago

Done.

Had to add test.check dependency in the circle-ci profile... I think we should make it a global dependency, we are doing that in #15. We can wait for that PR, or do it in a separate PR.

gfredericks commented 9 years ago

oh I think the problem is the with-profile call -- it's easy to mess up. with-profile foo runs with only the foo profile, whereas with-profile +foo will add the foo profile, which is what you want here. That way you still have the dev profile and thereby also the test.check dep.

nberger commented 9 years ago

Oh, thanks, didn't know that. Fixed it. Also squashed the commits, as it's a small change.

gfredericks commented 9 years ago

Looks great, thanks! Do they have a badge for the README?

nberger commented 9 years ago

Cool! :)

They have. Take a look into https://circleci.com/docs/status-badges, you have to get a token from the project settings in circle, then add one of those lines into the README.

gfredericks commented 9 years ago

thanks, I put it up

nberger commented 9 years ago

nice :)