Closed nberger closed 9 years ago
@gfredericks:
My proposal is to start using CircleCI as it's what I have used the most, and because it's very easy to setup. AFAIK this are the steps:
I think that's it, except because the build is hitting the memory limit in Circle. It seems that's because of the regex tests, but I'm not sure. Anyways, this PR fixes it by limiting the memory available to the JVM.
I setup circle-ci and attempted to modify the test command so that it uses a :circle-ci
profile -- can you modify this PR to put the jvm-opts inside such a profile?
This way it doesn't bother any other usage and is clear what it's for.
Sounds good. Perhaps it's better to tweak the test command for circle in a circle.yml file, so it's versioned. I'll do both, let's see how it works...
Done.
Had to add test.check
dependency in the circle-ci profile... I think we should make it a global dependency, we are doing that in #15. We can wait for that PR, or do it in a separate PR.
oh I think the problem is the with-profile
call -- it's easy to mess up. with-profile foo
runs with only the foo
profile, whereas with-profile +foo
will add the foo
profile, which is what you want here. That way you still have the dev
profile and thereby also the test.check dep.
Oh, thanks, didn't know that. Fixed it. Also squashed the commits, as it's a small change.
Looks great, thanks! Do they have a badge for the README?
Cool! :)
They have. Take a look into https://circleci.com/docs/status-badges, you have to get a token from the project settings in circle, then add one of those lines into the README.
thanks, I put it up
nice :)
Without this the build fails because it hits the 4GB mem limit