search

gfredericks / test.chuck

A utility library for test.check
Eclipse Public License 1.0
215 stars 26 forks source link

The test `exception-detection-test` is broken #23

Closed nberger closed 8 years ago

nberger commented 9 years ago

It got broken on the last change (#21). I'm not sure what's wrong: if the library code or the test code. Anyways, it's something that needs to be fixed.

gfredericks commented 9 years ago

I swear I ran the tests before merging that but maybe I didn't?

lackita commented 9 years ago

I thought I ran the tests as well, I'll take a look tonight.

nberger commented 9 years ago

Maybe. Who knows :)

What do you think about integrating something like Travis or Circle? I have it running in Circle in my fork, it just works given that new PR that sets Xmx=1g

gfredericks commented 9 years ago

I've never set up CI for an OSS project before -- I don't know what the options are or how to do it, but I'm not opposed.

gfredericks commented 9 years ago

circleCI definitely thinks it's failing

lackita commented 8 years ago

Alright, fixed the issue in #25. It seems I was led down the garden path because the failing test was named this-test-should-crash. I renamed it to this-test-should-crash-and-be-caught to clarify that intention.

nberger commented 8 years ago

I also think it's fixed now.