search

gfredericks / test.chuck

A utility library for test.check
Eclipse Public License 1.0
215 stars 26 forks source link

Replace calls to bounded-int with gen/large-integer* #42

Closed nberger closed 8 years ago

nberger commented 8 years ago

Avoids warnings due to calling a deprecated fn during cljs compilation.

Removes the following warning occurrences:

WARNING: com.gfredericks.test.chuck.generators/bounded-int is deprecated. at line 241 src/com/gfredericks/test/chuck/generators.cljc
WARNING: com.gfredericks.test.chuck.generators/bounded-int is deprecated. at line 242 src/com/gfredericks/test/chuck/generators.cljc
WARNING: com.gfredericks.test.chuck.generators/bounded-int is deprecated. at line 322 src/com/gfredericks/test/chuck/generators.cljc

The following warning is not removed because there's still a test for bounded-int in generators-test:

WARNING: com.gfredericks.test.chuck.generators/bounded-int is deprecated. at line 79 test/com/gfredericks/test/chuck/generators_test.cljc
gfredericks commented 8 years ago

oh hey nice I'm glad there's a warning

gfredericks commented 8 years ago

Is it the case that the first 3 warnings affect any CLJS user of test.chuck, while the last one only matters when compiling test.chuck itself?

nberger commented 8 years ago

Is it the case that the first 3 warnings affect any CLJS user of test.chuck, while the last one only matters when compiling test.chuck itself?

Exactly. That's how I found the warnings: compiling a cljs project that uses test.chuck.

gfredericks commented 8 years ago

Thanks!

nberger commented 8 years ago

Thanks for merging!

gfredericks commented 8 years ago

Released as well.

nberger commented 8 years ago

Cool!