search

gfredericks / test.chuck

A utility library for test.check
Eclipse Public License 1.0
214 stars 26 forks source link

Allow named groups in regex generation #62

Closed lvh closed 4 years ago

lvh commented 5 years ago

What it says on the tin. I hope.

lvh commented 5 years ago

Is Circle not supposed to build my branch?

gfredericks commented 5 years ago

I'm not sure how circle is configured; haven't gotten a PR in a while :)

gfredericks commented 5 years ago

Anyhow this sounds straightforward; I'll probably take a closer look in the next couple days.

Thanks!

gfredericks commented 5 years ago

Unfortunately I've noticed that the tests (on master) are currently failing on my java 12. I wonder if there have been regex changes between java 8 and 12.

Not the fault of this PR, obviously, but it makes it more of a pain to review. So I'm going to try to look into that as well.

gfredericks commented 5 years ago

Apparently at least one of the new features is \X, which was added in java 9, under the meaning of "Any Unicode extended grapheme cluster"

gfredericks commented 5 years ago

Also \N{WHITE SMILING FACE};

gfredericks commented 5 years ago

I just wrote up #63 to stand for the current build issues; I'd like to get that taken care of and then I'll come back to this.

gfredericks commented 4 years ago

Woo boy, okay, I think this works now. Sorry for the delay. This whole thing is pretty complicated and that's what I get for deciding to do something pretty complicated.

gfredericks commented 4 years ago

Released as version 0.2.10.

lvh commented 4 years ago

awesome, thanks!