search

gfredericks / test.chuck

A utility library for test.check
Eclipse Public License 1.0
214 stars 26 forks source link

Fix build, bump deps, support `times` in cljs #73

Closed frenchy64 closed 2 years ago

frenchy64 commented 2 years ago

Going out on a limb that this is a welcome change, but I saw the build has been broken for a while and PR's don't automatically run CI.

I took the opportunity to design a matrix build in Actions that uses times with different multipliers. Seems like a nice demo of its intended usage.

I noticed it's easy to support times in cljs too, so I added it.

gfredericks commented 2 years ago

oh man I had almost considered tweeting about this to see if anybody knew how to fix it

thanks!

gfredericks commented 2 years ago

Released as 0.2.12

frenchy64 commented 2 years ago

Thanks!

gfredericks commented 2 years ago

(incidentally, the build is still failing, though in a different way than before; maybe there's a change I have to make on circleci?)

frenchy64 commented 2 years ago

Yes, you need to stop CircleCI building this repo. Something like https://support.circleci.com/hc/en-us/articles/360021666393-How-to-stop-building-by-manually-removing-the-CircleCI-webhook-and-deploy-key-from-your-GitHub-repository

gfredericks commented 2 years ago

oh, you switched it to...github actions?

frenchy64 commented 2 years ago

Shame on me for not making that more obvious, but yes! Happy to figure out how to build with CircleCI if that's a problem.

gfredericks commented 2 years ago

oh no it's fine -- I just assumed it was so radically different because circleci had made a bunch of changes

do I need a different badge in the README, or is the build status automatically displayed somewhere so I should just delete the circleci one?

frenchy64 commented 2 years ago

:) Yes, delete the CircleCI badge.

If you want a badge, see here, though it doesn't seem to add much to me.

gfredericks commented 2 years ago

Perfect, thanks again!