gfreeau / cinnamon-pomodoro

64 stars 29 forks source link

No pomodoro count & Autostart after break can't be avoided #27

Closed akstrfn closed 9 years ago

akstrfn commented 10 years ago

My pomodoro count doesn't get increased in the Menu under "Completed" but initial counter displays me a big break after 4 pomodoro so it is just a graphical issue in the menu.

Also I have unchecked "Auto start a new pomodoro after the break ends" but still it autostarts after the break.

WhatFreshHellIsThis commented 10 years ago

+1 Old version I used to use worked perfectly, now it's quite flaky

gfreeau commented 10 years ago

I am using LM 16 and just tested these two issues.

My pomodoro counts under completed are updating correctly and with auto start disabled it does not start a new pomodoro.

What other options do you have enabled/disabled? What about the dialog messages?

It's possible the graphics issue happens on newer versions.

WhatFreshHellIsThis commented 10 years ago

LM 17, stock settings from install except I turned on timer tick sound, turned off autostart. It would do all manner of weird things like start ticking randomly after it had stopped, the count wouldn't go up as firtek stated. It would autostart even when off etc. Perhaps it's LM 17 related?

andralexxx commented 9 years ago

Same issue for me. I'm using LM17 and pomodoro starts ticking randomly after I stopped it. Another problem when I trying to reset Timer it continue countdown.

gfreeau commented 9 years ago

Can you provide:

To make this easier, go to ~/.local/share/cinnamon/applets/pomodoro@gregfreeman.org and modify

function convertMinutesToSeconds(minutes) {
    return minutes * 60; 
}

to

function convertMinutesToSeconds(minutes) {
    return minutes; 
}

and then restart cinnamon.

This will allow you to finish pomodoros in 25 seconds so you can do this process easier.

oneeman commented 9 years ago

Just tried this out today and thought I had a similar problem. After debugging a bit, I realized the count gets incremented after every long break. Likewise, when autostart is disabled, it autostarts after short breaks, but not after long breaks.

Looking at the code it seems like that's the intended behavior, since the dialog and the increment are set to happen when the queue is finished, not when each break starts or each pomodoro timer stops. But I find this confusing, since I thought a pomodoro was a 25 minute interval between any breaks, not a group of such intervals between the long breaks. I'm new to this whole pomodoro system, though.

@gfreeau Any thoughts?

oneeman commented 9 years ago

Related to https://github.com/gfreeau/cinnamon-pomodoro/issues/34. Looking at the wikipedia section referenced there, as well as the pomodoro technique page itself, I believe the correct behavior would be to increment the count after every pomodoro (both short breaks and long breaks) not after every set (only at long breaks).

oneeman commented 9 years ago

Just saw https://github.com/gfreeau/cinnamon-pomodoro/pull/35, which I believe addresses this, among other changes.

P.S. sorry for the repeated comments, just noticed the other issue/PR later.