Closed Fllorent0D closed 5 years ago
Ah ok. Didn't check what was the pid, I thought the player id was based on the player's unique index.
That info would be great to have from my side. A lot of users want their "provisional" ranking directly in the application but they don't have enough permissions.
Sure, the need is obvious but it won't work as proposed...
Two changes are required:
Thanks for your help.
Updated the PR. What do you think about it ? 😊
Looks great! Thanks a lot. Will integrate this soon and let you know.
Any idea when it will be integrated ? 😊
The good question is "What can I do to help speeding up thing?".
And the answer would be : can you have a look at the portion under if ($OnBehalfOf > 0)
, there we may also need to add something (not sure what though, need to look into the details but currently no time to do so...).
Thanks ! Nice work !
Is it deployed on both vttl and afft instance? or is the config set to allow the retrieving of the rankings?
Yes it is but the flag (allow_own_ranking_info) was not set. Just did it now for AFTT.
Tried this morning and I didn't see any changes on my profile. Something might be wrong somewhere
Nevermind it's working
My bad, one file was not correctly merged.
Note that I made some more tests and strengthened a bit the required permissions to better match reality (VTTL players shall not have access to this information if they are using the AF API).
There was also a security glitch with the OnBehalfOf that is now fixed.
Thanks Florent. But that will not work :-/
"pid" is the internal player identifier and "UniqueIndex" is the external member license number.
Moreover, we need to make this optionally configurable by the API admin because this option does not match what is currently possible on the website.
I mean: on the website, you have to have the admin or classement right to see this information.