feat: DivisionId in GetMatchResponse

gfrenoy / TabT-API

Programming interface for TabT, the free table tennis manager software

http://tabt.frenoy.net

GNU Affero General Public License v3.0

9 stars 5 forks source link

feat: DivisionId in GetMatchResponse #8

Closed Fllorent0D closed 5 years ago

Fllorent0D commented 5 years ago

I need to receive the DivisionId from GetMatch to remove a bug in BePing. Without this I can't redirect reliably from a page you see results to a page with a division ranking.

CLAassistant commented 5 years ago

All committers have signed the CLA.

gfrenoy commented 5 years ago

Thanks !

Two remarks:

sometimes better to add new parameters at the end of the existing sequence ; otherwise it may break some (old and not well written...) implementations. At least make it optional.
Don't forget to update the documentation accordingly!

Fllorent0D commented 5 years ago

Thank you. I take note of the remarks 😊

gfrenoy commented 5 years ago

Fyi, code is up-to-date and new version is published on AFTT & VTTL websites.

Fllorent0D commented 5 years ago

Ok thx! Next time you have remarks don't merge it directly, let me fix my errors first to ensure code quality.